Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold experiments #8

Open
wants to merge 12 commits into
base: dashboard_dev
Choose a base branch
from
Open

Fold experiments #8

wants to merge 12 commits into from

Conversation

mmalczak
Copy link
Collaborator

@mmalczak mmalczak commented Feb 1, 2025

I have refactored the code for ease of development.
I have added independent layouts, one with widgets that cannot be folded and another one with widgets to fold.

@mmalczak mmalczak requested a review from marmeladapk February 1, 2025 21:33
Copy link
Collaborator

@marmeladapk marmeladapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add maximum height for submit and terminate buttons
    image
  • Minimum width is too low when scheduler settings are hidden -
    image
    image
    • maybe make a single large row for recompute and load buttons
    • maybe base minimum width on parameters - this might be tricky if there are groups
  • expand window to new minimum width when expanding scheduler settings (now it's expanded when moving/resizing)
    image
  • remember state of managment expansion
  • add text next to the expansion button "expand/hide scheduler settings"

@mmalczak mmalczak requested a review from marmeladapk February 4, 2025 23:07
@marmeladapk
Copy link
Collaborator

Buttons are resized, but still the whole panel housing them scales.
image

Expanding and collapsing options changes the window size even if it's larger than minimum.

Minimum width seems to be the same as on upstream now regardless if settings are expanded or collapsed. I wanted to be able to make the window narrower with collapsed options.

Change text "Options" to "Scheduler settings" (it's called that elsewhere in the GUI).

@mmalczak
Copy link
Collaborator Author

mmalczak commented Feb 7, 2025

Implemented

Copy link
Collaborator

@marmeladapk marmeladapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you did there with load and recompute buttons. :)

I guess that's acceptable, but you should increase minimum width for the leftmost column in arguments. With short argument names text on "load hdf" button will clip.
image

Resizing when expanding settings is still not there:
When you have a tall but narrow window and expand settings then it expands horizontally but shrinks vertically. It should maintain its vertical size if it's above minimum you set.
image
image

When expanding settings on short (below minimum height for expanded state) but wide window the window is not resized unless moved.
image
image

Please test how the experiment windows of different sizes behave when expanding and collapsing settings.

There's no indication that scheduler settings are not default (as per discussion on discord).

@mmalczak
Copy link
Collaborator Author

Above mentioned issues are fixed.

Indication about non-default scheduler settings will be done in #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants