-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fold experiments #8
base: dashboard_dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add maximum height for submit and terminate buttons
- Minimum width is too low when scheduler settings are hidden -
- maybe make a single large row for recompute and load buttons
- maybe base minimum width on parameters - this might be tricky if there are groups
- expand window to new minimum width when expanding scheduler settings (now it's expanded when moving/resizing)
- remember state of managment expansion
- add text next to the expansion button "expand/hide scheduler settings"
Implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you did there with load and recompute buttons. :)
I guess that's acceptable, but you should increase minimum width for the leftmost column in arguments. With short argument names text on "load hdf" button will clip.
Resizing when expanding settings is still not there:
When you have a tall but narrow window and expand settings then it expands horizontally but shrinks vertically. It should maintain its vertical size if it's above minimum you set.
When expanding settings on short (below minimum height for expanded state) but wide window the window is not resized unless moved.
Please test how the experiment windows of different sizes behave when expanding and collapsing settings.
There's no indication that scheduler settings are not default (as per discussion on discord).
Above mentioned issues are fixed. Indication about non-default scheduler settings will be done in #5 |
I have refactored the code for ease of development.
I have added independent layouts, one with widgets that cannot be folded and another one with widgets to fold.