Fix running tests #598
Merged
Fix running tests #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```console
$ cd test && python3 all_tests.py
Traceback (most recent call last):
File "…/pyelftools/test/all_tests.py", line 29, in <module>
sys.exit(main())
^^^^^^
File "…/pyelftools/test/all_tests.py", line 21, in main
testlog.error('Error: Please run me from the root dir of pyelftools!')
^^^^^^^
NameError: name 'testlog' is not defined
```
Signed-off-by: Philipp Hahn <[email protected]>
Otherwise the output of `readelf` might be translated and comparison with the English output from `readelf.py` will fail. ```console $ LC_ALL=de_DE.UTF-8 ./test/run_readelf_tests.py Test file 'test/testfiles_for_readelf/aarch64-pac-bti.elf' .......................FAIL ....for file test/testfiles_for_readelf/aarch64-pac-bti.elf ....for option "-e" ....Output eliben#1 is readelf, Output eliben#2 is pyelftools @@ Mismatch on line #0: >>elf-header:<< >>elf header:<< ([('equal', 0, 3, 0, 3), ('replace', 3, 4, 3, 4), ('equal', 4, 11, 4, 11)]) ``` Signed-off-by: Philipp Hahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #514 I noticed two issues while running the test suite:
testlogis used but not defined