feat(node): custom Buffer implementation

[darvld]

Summary

Adds a custom implementation of the Node.js Buffer class, for use both as a global symbol and as part of the node:buffer built-in module. Two new interfaces are added: BufferInstance represents actual Buffer objects, with BufferClass serving as meta-object, holding all static (class-level) properties and methods.

This means that when injected into a guest context, there should only be one instance of BufferClass, which is bound as the Buffer symbol (and inside node:buffer), which can in turn be used to create multiple BufferInstance objects using the Node.js API.

Pending changes

The following changes are vital to the feature and currently block merge:

• ProxyObject implementation for BufferClass.
• Update the node:buffer builtin module to use the new implementation.
• Inject a BufferClass instance as a global Buffer symbol.
• Remove the Buffer polyfill and ensure only the new implementation is available in guest contexts.
• Extensive testing for the Buffer APIs.

[sonarcloud]

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 51.26147% with 425 lines in your changes missing coverage. Please review.

Project coverage is 52.55%. Comparing base (84ec973) to head (40acda6).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   53.17%   52.55%   -0.62%     
==========================================
  Files         405      413       +8     
  Lines       14207    15055     +848     
  Branches     2394     2720     +326     
==========================================
+ Hits         7554     7912     +358     
- Misses       5903     6236     +333     
- Partials      750      907     +157     

Flag	Coverage Δ
jvm	52.55% <51.26%> (-0.62%)	⬇️
lib	52.55% <51.26%> (-0.62%)	⬇️
native	79.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...de/runtime/gvm/internals/node/buffer/NodeBuffer.kt	47.69% <100.00%> (+0.81%)	⬆️
.../elide/runtime/intrinsics/js/node/FilesystemAPI.kt	85.71% <ø> (ø)
...de/runtime/gvm/internals/node/stream/NodeStream.kt	34.49% <0.00%> (ø)
...ntime/gvm/internals/node/buffer/GuestBufferView.kt	81.81% <81.81%> (ø)
...de/runtime/gvm/internals/node/fs/NodeFilesystem.kt	63.24% <0.00%> (ø)
...de/runtime/gvm/internals/node/buffer/GuestBytes.kt	57.14% <57.14%> (ø)
...e/runtime/intrinsics/js/node/buffer/BufferClass.kt	0.00% <0.00%> (ø)
...untime/intrinsics/js/node/buffer/BufferInstance.kt	75.75% <75.75%> (ø)
...me/gvm/internals/node/buffer/NodeBufferEncoding.kt	50.00% <50.00%> (ø)
...untime/gvm/internals/node/buffer/NodeHostBuffer.kt	60.78% <60.78%> (ø)
... and 3 more

... and 11 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ec973...40acda6. Read the comment docs.