Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: entrypoint work pt 4 #1084

Merged
merged 38 commits into from
Jul 15, 2024
Merged

feat: entrypoint work pt 4 #1084

merged 38 commits into from
Jul 15, 2024

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Jul 14, 2024

Draft Powered by Pull Request Badge

Summary

Continued general work toward new entrypoint, via Clikt and Rust. For the first time, Elide can actually be run through the CLI entrypoint using this new setup.

Pass ELIDE_EXPERIMENTAL=true to enable this new code path. No options or arguments are supported yet.

  • Continued work on our native Rust layer
  • Many build fixes, simplification of native library build-and-test
  • Initial support at build-time for Python stuff (venv, Pip deps, Ruff, etc.)

Changelog

  • feat(base): optimized rust routines for encodings
  • feat(base): build under no_std
  • feat(model): model crate initial structure
  • feat(sqlite): implement rust sqlite api layer
  • feat(project): new project crate
  • fix: sqlite symbol access from umbrella
  • fix: don't strip cargo outputs
  • fix: many fixes for builder crates
  • fix: don't move around third party libs
  • fix: clean for zlib and sqlite
  • fix: sqlite build flags aren't making it in
  • fix: rename core crate to base
  • fix: dynamic/static library builds for crates
  • fix(sqlite): loading of native sqlite libs in native image
  • chore: run cargo test with make test
  • chore: add some basic jvm and native encoding benchmarks
  • chore: merge cli-bridge module into cli
  • chore: rewrite CliNativeBridge in kotlin
  • chore: initial build wiring for protocol models in rust
  • chore: makefile support for ccache and sccache
  • chore: cargo fuzz support
  • chore: run cargo update
  • chore: run clippy
  • chore: run fmt
  • chore: update module pins, baselines
  • chore: update verification metadata + lockfiles
  • chore: update kotlinx benchmark → 0.4.11
  • chore: update gradle → 8.9
  • chore: update kotlin → 2.0.10-RC
  • chore: update ksp → 2.0.10-RC-1.0.23

@sgammon sgammon added feature Large PRs or issues with full-blown features 🚧 WIP Works-in-progress. Blocks merge module:cli CLI module issues and features labels Jul 14, 2024
@sgammon sgammon added this to the Release R7: Beta 1 milestone Jul 14, 2024
@sgammon sgammon self-assigned this Jul 14, 2024
@sgammon sgammon force-pushed the feat/entrypoint-v2-pt4 branch 2 times, most recently from d3b2f89 to 7d4bc26 Compare July 14, 2024 03:44
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to exclude these from being formatted by biome

@sgammon sgammon force-pushed the feat/entrypoint-v2-pt4 branch 2 times, most recently from eeb3046 to 99f921e Compare July 14, 2024 19:20
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 71.10390% with 178 lines in your changes missing coverage. Please review.

Project coverage is 53.18%. Comparing base (4e85082) to head (4c42b15).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
+ Coverage   48.19%   53.18%   +4.99%     
==========================================
  Files         394      405      +11     
  Lines       13653    14207     +554     
  Branches     2339     2394      +55     
==========================================
+ Hits         6580     7556     +976     
+ Misses       6361     5898     -463     
- Partials      712      753      +41     
Flag Coverage Δ
gradle ?
jvm 53.18% <71.10%> (+4.99%) ⬆️
lib 53.18% <71.10%> (+4.99%) ⬆️
native 79.39% <79.61%> (?)
plugin ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
crates/base/src/crc.rs 100.00% <100.00%> (ø)
...ckages/cli/src/main/kotlin/elide/tool/cli/Elide.kt 36.79% <ø> (ø)
crates/entry/src/bin/elide.rs 70.00% <83.33%> (ø)
...c/main/kotlin/elide/tool/cli/AbstractSubcommand.kt 63.93% <90.00%> (+9.23%) ⬆️
...otlin/elide/tool/cli/cmd/tool/ToolInvokeCommand.kt 1.89% <0.00%> (ø)
crates/model/src/lang.rs 92.59% <92.59%> (ø)
crates/project/src/config.rs 0.00% <0.00%> (ø)
.../main/kotlin/elide/tool/cli/AbstractToolCommand.kt 62.31% <0.00%> (-4.85%) ⬇️
...in/elide/runtime/plugins/AbstractLanguagePlugin.kt 0.00% <0.00%> (ø)
crates/deps/src/catalog.rs 0.00% <0.00%> (ø)
... and 9 more

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e85082...4c42b15. Read the comment docs.

@sgammon sgammon added the ci:buf-breaking-ignore Ignore breaking proto changes label Jul 14, 2024
@sgammon sgammon force-pushed the feat/entrypoint-v2-pt4 branch 2 times, most recently from 12972b5 to cacc63a Compare July 15, 2024 01:55
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

if gvm_home_var.is_none() {
env!("JAVA_HOME")
} else {
env!("GRAALVM_HOME")

Check failure

Code scanning / clippy

environment variable GRAALVM_HOME not defined at compile time Error

environment variable GRAALVM\_HOME not defined at compile time
Copy link

socket-security bot commented Jul 15, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

- feat(base): optimized rust routines for encodings
- feat(base): build under `no_std`
- feat(model): `model` crate initial structure
- feat(sqlite): implement rust sqlite api layer
- feat(project): new project crate
- fix: sqlite symbol access from umbrella
- fix: don't strip cargo outputs
- fix: many fixes for `builder` crates
- fix: don't move around third party libs
- fix: clean for zlib and sqlite
- fix: sqlite build flags aren't making it in
- fix: rename `core` crate to `base`
- fix: dynamic/static library builds for crates
- fix(sqlite): loading of native sqlite libs in native image
- chore: run `cargo test` with `make test`
- chore: add some basic jvm and native encoding benchmarks
- chore: merge `cli-bridge` module into `cli`
- chore: rewrite `CliNativeBridge` in kotlin
- chore: initial build wiring for protocol models in rust
- chore: makefile support for ccache and sccache
- chore: `cargo fuzz` support
- chore: run `cargo update`
- chore: run clippy
- chore: run fmt
- chore: update module pins, baselines
- chore: update verification metadata + lockfiles
- chore: update kotlinx benchmark → `0.4.11`
- chore: update gradle → `8.9`
- chore: update kotlin → `2.0.10-RC`
- chore: update ksp → `2.0.10-RC-1.0.23`

Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon force-pushed the feat/entrypoint-v2-pt4 branch 2 times, most recently from b60f01f to 561af5e Compare July 15, 2024 06:51
Comment on lines 341 to 345
} else {
if let Some(gvm_home) = gvm_home_var {
gvm_home
} else {
gvm_home_val
env!("JAVA_HOME")
}
}

Check failure

Code scanning / clippy

this else { if .. } block can be collapsed Error

this else { if .. } block can be collapsed
sgammon and others added 6 commits July 15, 2024 00:40
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@65a9edc...fa0a91b)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@d70bba7...4fd8129)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/docker/setup-qemu-action/releases)
- [Commits](docker/setup-qemu-action@6882732...5927c83)

---
updated-dependencies:
- dependency-name: docker/setup-qemu-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@6546280...0b2256b)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Copy link

sonarcloud bot commented Jul 15, 2024

@sgammon sgammon marked this pull request as ready for review July 15, 2024 08:50
@sgammon sgammon merged commit f5081fa into main Jul 15, 2024
23 checks passed
@sgammon sgammon deleted the feat/entrypoint-v2-pt4 branch July 15, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:buf-breaking-ignore Ignore breaking proto changes feature Large PRs or issues with full-blown features module:cli CLI module issues and features 🚧 WIP Works-in-progress. Blocks merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant