Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lazy jar parsing, indexer internals #71

Merged
merged 20 commits into from
Mar 30, 2024
Merged

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Mar 28, 2024

  • feat(java): parse jars lazily to avoid strong initial overhead
  • feat(indexer): implement indexer internals for jars
  • test(java): add benchmarks for jar reading
  • fix: relative imports should use .js

- feat(java): parse jars lazily to avoid strong initial overhead
- feat(indexer): implement indexer internals for jars
- test(java): add benchmarks for jar reading
- fix: relative imports should use `.js`

Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon added enhancement New feature or request ✋ embargoed Waiting for further action labels Mar 28, 2024
@sgammon sgammon self-assigned this Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 70.99768% with 125 lines in your changes are missing coverage. Please review.

Project coverage is 91.11%. Comparing base (e0ed7ab) to head (3ba4ef6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   94.60%   91.11%   -3.50%     
==========================================
  Files          28       28              
  Lines        5712     5897     +185     
  Branches      382      363      -19     
==========================================
- Hits         5404     5373      -31     
- Misses        304      518     +214     
- Partials        4        6       +2     
Flag Coverage Δ
packages 91.11% <70.99%> (-3.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/java/java-classfile.ts 97.03% <100.00%> (-0.90%) ⬇️
packages/java/java-home.ts 95.16% <100.00%> (ø)
packages/java/javaclasses/constant-pool.ts 94.54% <100.00%> (ø)
packages/java/javaclasses/instruction-parser.ts 76.64% <100.00%> (ø)
packages/java/javaclasses/java-class-reader.ts 79.97% <100.00%> (-16.00%) ⬇️
packages/java/toolchain/abstract.ts 97.30% <100.00%> (ø)
packages/java/toolchain/compiler.ts 100.00% <100.00%> (ø)
packages/java/toolchain/index.ts 100.00% <100.00%> (ø)
packages/java/toolchain/launcher.ts 100.00% <100.00%> (ø)
packages/java/toolchain/repositories.ts 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0ed7ab...3ba4ef6. Read the comment docs.

sgammon added 19 commits March 29, 2024 15:47
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
- feat: generate top-level project summary indexes
- feat: project profile info and model
- fix: various parsing issues in maven pom parser
- chore: begin work on maven project facade (coming soon)

Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon marked this pull request as ready for review March 30, 2024 05:13
@sgammon sgammon merged commit 8145c6b into main Mar 30, 2024
9 checks passed
@sgammon sgammon deleted the feat/lazy-jar-parsing branch March 30, 2024 05:13
@sgammon sgammon removed the ✋ embargoed Waiting for further action label Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant