Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 763 #763

Merged
merged 2 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/preprint-changes.xsl
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,7 @@

<!-- Fixes mistagged preprints -->
<xsl:template xml:id="find-and-tag-preprint-refs" mode="mixed-citation-round-4" match="mixed-citation">
<xsl:variable name="preprint-regex" select="'^(biorxiv|africarxiv|arxiv|cell\s+sneak\s+peak|chemrxiv|chinaxiv|eartharxiv|medrxiv|osf\s+preprints|paleorxiv|peerj\s+preprints|preprints|preprints\.org|psyarxiv|research\s+square|scielo\s+preprints|ssrn|vixra)$'"/>
<xsl:variable name="preprint-regex" select="'^(biorxiv|africarxiv|arxiv|cell\s+sneak\s+peak|chemrxiv|chinaxiv|eartharxiv|medrxiv|osf\s+preprints|paleorxiv|peerj\s+preprints|preprints|preprints\.org|psyarxiv|research\s+square|scielo\s+preprints|ssrn|vixra|ecoevorxiv)$'"/>
<xsl:copy>
<xsl:choose>
<xsl:when test="@publication-type!='preprint' and matches(lower-case(source[1]),$preprint-regex)">
Expand Down
14 changes: 14 additions & 0 deletions src/rp-schematron-base.sch
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,14 @@
<report test="matches(lower-case($article-text),'biorend[eo]r')"
role="warning"
id="biorender-check">Article text contains a reference to bioRender. Any figures created with bioRender should include a sentence in the caption in the format: "Created with BioRender.com/{figure-code}".</report>

<assert test="sub-article[@article-type='editor-report']"
role="error"
id="no-assessment">A Reviewed Preprint must have an eLife Assessment, but this one does not.</assert>

<assert test="sub-article[@article-type='referee-report']"
role="error"
id="no-public-review">A Reviewed Preprint must have at least one Public Review, but this one does not.</assert>

<report test="$is-revised-rp and not(sub-article[@article-type='author-comment'])"
role="warning"
Expand Down Expand Up @@ -749,6 +757,12 @@
role="warning"
id="mixed-citation-person-group-flag-2"><name/> in reference (id=<value-of select="ancestor::ref/@id"/>) does not have an author person-group. Is that correct?</assert>
</rule>

<rule context="mixed-citation/*" id="mixed-citation-child-checks">
<report test="not(*) and (normalize-space(.)='')"
role="error"
id="mixed-citation-child-1"><name/> in reference (id=<value-of select="ancestor::ref/@id"/>) is empty, which cannot be correct.</report>
</rule>
</pattern>

<pattern id="back">
Expand Down
8 changes: 7 additions & 1 deletion src/rp-schematron.sch
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@
<let name="rp-version" value="replace(descendant::article-meta[1]/article-id[@specific-use='version'][1],'^.*\.','')"/>

<report test="matches(lower-case($article-text),'biorend[eo]r')" role="warning" id="biorender-check">[biorender-check] Article text contains a reference to bioRender. Any figures created with bioRender should include a sentence in the caption in the format: "Created with BioRender.com/{figure-code}".</report>

<assert test="sub-article[@article-type='editor-report']" role="error" id="no-assessment">[no-assessment] A Reviewed Preprint must have an eLife Assessment, but this one does not.</assert>

<assert test="sub-article[@article-type='referee-report']" role="error" id="no-public-review">[no-public-review] A Reviewed Preprint must have at least one Public Review, but this one does not.</assert>

<report test="$is-revised-rp and not(sub-article[@article-type='author-comment'])" role="warning" id="no-author-response-1">[no-author-response-1] Revised Reviewed Preprint (version <value-of select="$rp-version"/>) does not have an author response, which is unusual. Is that correct?</report>

Expand Down Expand Up @@ -443,7 +447,9 @@
<report test="*[name()=$name-elems]" role="error" id="mixed-citation-person-group-flag-1">[mixed-citation-person-group-flag-1] <name/> in reference (id=<value-of select="ancestor::ref/@id"/>) has child name elements (<value-of select="string-join(distinct-values(*[name()=$name-elems]/name()),'; ')"/>). These all need to be placed in a person-group element with the appropriate person-group-type attribute.</report>

<assert test="person-group[@person-group-type='author']" role="warning" id="mixed-citation-person-group-flag-2">[mixed-citation-person-group-flag-2] <name/> in reference (id=<value-of select="ancestor::ref/@id"/>) does not have an author person-group. Is that correct?</assert>
</rule></pattern>
</rule></pattern><pattern id="mixed-citation-child-checks-pattern"><rule context="mixed-citation/*" id="mixed-citation-child-checks">
<report test="not(*) and (normalize-space(.)='')" role="error" id="mixed-citation-child-1">[mixed-citation-child-1] <name/> in reference (id=<value-of select="ancestor::ref/@id"/>) is empty, which cannot be correct.</report>
</rule></pattern>

<pattern id="back-tests-pattern"><rule context="back" id="back-tests">

Expand Down
Loading
Loading