remove about page and its tests (#1772)

* remove about page and its tests

* remove from critical-css

* More stuff

* fix tests

---------

Co-authored-by: Saeed Moghadamzadeh <[email protected]>
Co-authored-by: nlisgo <[email protected]>

app/Resources/views/about-people.html.twig

@@ -8,12 +8,6 @@
 
     {{ render_pattern(contentHeader) }}
 
-    <div class="wrapper">
-
-        {{ render_pattern(menuLink) }}
-
-    </div>
-
     {% include 'calls-to-action.html.twig' %}
 
     {% embed 'grid/listing-one-column.html.twig' with {fullWidth: true} %}

app/config/routing.yml

@@ -21,40 +21,18 @@ home:
 
 about:
     path: /about
-    defaults:
-         _controller: AppBundle:About:about
-
-about-aims-scope:
-    path: /about/aims-scope
-    defaults:
-         _controller: AppBundle:About:aimsScope
 
-about-research-culture:
-    path: /about/research-culture
-    defaults:
-         _controller: AppBundle:About:researchCulture
-
-about-technology:
-    path: /about/technology
-    defaults:
-         _controller: AppBundle:About:technology
-
-about-peer-review:
-    path: /about/peer-review
-    defaults:
-         _controller: AppBundle:About:peerReview
+about-pubpub:
+    path: /about/{type}
+    requirements:
+      type: '(aims-scope|research-culture|technology|peer-review|publishing-with-elife)'
 
 about-people:
     path: /about/people/{type}
     defaults:
          _controller: AppBundle:About:people
          type: ''
 
-about-publishing-with-elife:
-    path: /about/publishing-with-elife
-    defaults:
-         _controller: AppBundle:About:publishingWithElife
-
 alerts:
     path: /alerts
     defaults:

critical-css.json

@@ -1,6 +1,5 @@
 {
     "default": "/resources",
-    "about": "/about",
     "article": "/articles/00569",
     "archive-month": "/archive/2016/march",
     "landing": "/subjects/cancer-biology",

src/Controller/ArticlesController.php

@@ -314,7 +314,7 @@ private function createFirstPage(Request $request, string $id, array $arguments)
                     $first = true;
                     $relatedLinks = [];
 
-                    $relatedLinks[] = new Link('About eLife assessments', $this->get('router')->generate('about-peer-review'));
+                    $relatedLinks[] = new Link('About eLife assessments', $this->get('router')->generate('about-pubpub', ['type'=> 'peer-review']));
 
                     $parts[] = ArticleSection::collapsible(
                         'elife-assessment',
@@ -344,7 +344,7 @@ private function createFirstPage(Request $request, string $id, array $arguments)
                         $relatedLinks[] = new Link('Reviews on Sciety', $item->getEditorEvaluationScietyUri());
                     }
 
-                    $relatedLinks[] = new Link('eLife\'s review process', $this->get('router')->generate('about-peer-review'));
+                    $relatedLinks[] = new Link('eLife\'s review process', $this->get('router')->generate('about-pubpub', ['type'=> 'peer-review']));
 
                     $parts[] = ArticleSection::collapsible(
                         $item->getEditorEvaluation()->getId() ?? 'editor-evaluation',

src/Controller/CommunityController.php

@@ -56,7 +56,7 @@ private function createFirstPage(array $arguments) : Response
             'Community',
             $this->get('elife.journal.view_model.factory.content_header_image')->forLocalFile('community'),
             'The eLife community is working to help address some of the pressures on early-career scientists in a number of ways.
-Learn more about <a href="'.$this->get('router')->generate('about-research-culture').'">our work</a> and <a href="'.$this->get('router')->generate('about-people', ['type' => 'early-career']).'">advisory group</a>, <a href="https://crm.elifesciences.org/crm/community-news">sign up for our monthly news</a>,
+Learn more about <a href="'.$this->get('router')->generate('about-pubpub', ['type' => 'research-culture']).'">our work</a> and <a href="'.$this->get('router')->generate('about-people', ['type' => 'early-career']).'">advisory group</a>, <a href="https://crm.elifesciences.org/crm/community-news">sign up for our monthly news</a>,
 follow us on <a href="https://www.twitter.com/elifecommunity">Twitter</a>, and explore recent activities below.'
         );
 

src/Controller/LabsController.php

@@ -66,7 +66,7 @@ private function createFirstPage(array $arguments) : Response
             'eLife Labs',
             $this->get('elife.journal.view_model.factory.content_header_image')->forLocalFile('labs'),
             'Exploring open-source solutions at the intersection of research and technology.
-            Learn more about <a href="'.$this->get('router')->generate('about-technology').'">innovation at eLife</a>, follow us on <a href="https://twitter.com/eLifeInnovation">Twitter</a>, or sign up for our <a href="https://crm.elifesciences.org/crm/tech-news?utm_source=Labs-home&utm_medium=website&utm_campaign=technews">technology and innovation newsletter</a>.'
+            Learn more about <a href="'.$this->get('router')->generate('about-pubpub', ['type'=> 'technology']).'">innovation at eLife</a>, follow us on <a href="https://twitter.com/eLifeInnovation">Twitter</a>, or sign up for our <a href="https://crm.elifesciences.org/crm/tech-news?utm_source=Labs-home&utm_medium=website&utm_campaign=technews">technology and innovation newsletter</a>.'
         );
 
         return new Response($this->get('templating')->render('::labs.html.twig', $arguments));