Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource param to FhirCodeService #241

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Add resource param to FhirCodeService #241

merged 2 commits into from
Mar 25, 2024

Conversation

semicolin
Copy link
Collaborator

@semicolin semicolin commented Mar 25, 2024 •
edited
Loading

Overview

  • Adds a resource param to FhirCodeService.getName()
  • This allows a custom implementation to use other resource properties (e.g. extensions) to determine the name

How it was tested

  • Ran unit tests

Checklist

  • The title contains a short meaningful summary
  • I have added a link to this PR in the Jira issue
  • I have described how this was tested
  • I have included screen shots for changes that affect the user interface
  • I have updated unit tests
  • I have run unit tests locally
  • I have updated documentation (including README)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 25, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@semicolin semicolin marked this pull request as ready for review March 25, 2024 14:33
dimon37
dimon37 approved these changes Mar 25, 2024
View reviewed changes
Copy link

@dimon37 dimon37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense,.

@semicolin semicolin merged commit ee224c9 into main Mar 25, 2024
6 checks passed
@semicolin semicolin deleted the code-service-resource branch March 25, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimon37 dimon37 dimon37 approved these changes

@yashpmohod yashpmohod Awaiting requested review from yashpmohod

@shubhamparikh927 shubhamparikh927 Awaiting requested review from shubhamparikh927

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@semicolin @dimon37