Updated the observation mapper to use valueQuantity.code

[shubhamparikh927]

Overview

• Updated the observation mapper to use valueQuantity.code
• Updated the unit test case

How it was tested

• Tested by running showcase app locally

Checklist

• The title contains a short meaningful summary
• I have added a link to this PR in the Jira issue
• I have described how this was tested
• I have included screen shots for changes that affect the user interface
• I have updated unit tests
• I have run unit tests locally
• I have updated documentation (including README)

[semicolin]

This is a potentially high-impact change. I'm going to do some testing on this branch.

[semicolin]

I don't think we should merge this PR. It could result in inaccurate information being displayed in the chart. For example, the demo patient "Ocelot Apricot" has multiple hemoglobin observations. Some are measured in mmol/L and others are measured in g/dL. In this branch, they both show up on the same scale, which is labelled g/dL. The measurement of 15 mmol/L is misrepresented as 15 g/dL. Those are not equivalent. We would need to do unit conversion in order to display those on the same chart.

Instead, we should change the observation mappers to use resource.valueQuantity.code instead of resource.valueQuantity.unit for the scale label. That will eliminate duplicate layers that are caused by cosmetic differences in the human-readable display units without merging layers that really use different units of measure.

We should also continue troubleshooting the bugs that we see when there are two layers with the same name. We should be able to support multiple layers with the same name. Maybe it is actually an issue with the dataset labels being the same? Dataset labels do need to be unique due to chart.js requirement.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud