Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts on fhir update to angular 17 #252

Merged
merged 22 commits into from
Jun 24, 2024
Merged

charts on fhir update to angular 17 #252

merged 22 commits into from
Jun 24, 2024

Conversation

shubhamparikh927
Copy link
Contributor

@shubhamparikh927 shubhamparikh927 commented Jun 13, 2024 •
edited
Loading

Overview

  • Updated the angular version to 17 using nx migrate [email protected]
  • Updated the ng-doc to the latest version to 17.6.13
  • Updated all modules to the standalone components.
  • Used the built-in fullscreen mode for chart layout component

How it was tested

  • Tested by running the showcase and documentation app locally
  • Also tested by running the showcase app using the docker
  • Ran unit test case locally

Checklist

  • The title contains a short meaningful summary
  • I have added a link to this PR in the Jira issue
  • I have described how this was tested
  • I have included screen shots for changes that affect the user interface
  • I have updated unit tests
  • I have run unit tests locally
  • I have updated documentation (including README)

semicolin
semicolin requested changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@semicolin semicolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation build is failing

nx.json Show resolved Hide resolved
semicolin
semicolin requested changes Jun 14, 2024
View reviewed changes
tsconfig.base.json Outdated Show resolved Hide resolved
apps/documentation/tsconfig.json Outdated Show resolved Hide resolved
apps/documentation/src/app/app.module.ts Outdated Show resolved Hide resolved
.../app/pages/components/timeline-range-selector/demo/timeline-range-selector-demo.component.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 24, 2024

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@shubhamparikh927 shubhamparikh927 merged commit 78ac59a into main Jun 24, 2024
5 checks passed
@shubhamparikh927 shubhamparikh927 deleted the RT-1025-charts-on-fhir-update-to-angular-17 branch June 24, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semicolin semicolin semicolin approved these changes

@vdeshkar vdeshkar vdeshkar approved these changes

@yashpmohod yashpmohod yashpmohod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shubhamparikh927 @semicolin @vdeshkar @yashpmohod