Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs, tests, updates, bug fixes, and more #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kiwi
Copy link

@Kiwi Kiwi commented Apr 20, 2020

use nixos-unstable channel by default
improved and updated documentation
tested and documented installing on different DO Images
fix install on Debian (requires xz-utils)
fix networking.nix formatting
fix networking.nix (eth1) interface detection
use a few (not all! some are wrong!) shellcheck suggestions

Hi! I did this a long time ago but didn't get around to making a PR... and now there are conflicts I see and possibly a fix for something I fixed (debian 10). I can resolve that if you like if this is a PR you're interested in. am maybe also willing to work with to make it something you are if it's not good as is. I did a lot of other improvements too. I can remove the change to use nixos-unstable too as that's probably not what you want.

use nixos-unstable channel by default
improved and updated documentation
tested and documented installing on different DO Images
fix install on Debian (requires xz-utils)
fix networking.nix formatting
fix networking.nix (eth1) interface detection
use a few (not all! some are wrong!) shellcheck suggestions
@elitak
Copy link
Owner

elitak commented Apr 20, 2020

Yeah, I'd merge this if you could clear up the conflicts. Omit the nixos-unstable change.

I'm ambivalent about bloating up the file with documentation, but I suppose it's better to err on the side of too much, rather than too little.

Appreciate the help; thanks.

@DavHau
Copy link
Contributor

DavHau commented Apr 21, 2020

Why do yo want to use the nixos-unstable branch by default? Wouldn't it be better do have the defaults as 'stable' as possible?

@Kiwi
Copy link
Author

Kiwi commented Apr 21, 2020

@DavHau i use nixos-unstable so that's what i had. :) simple as that. i'm modifying that part of it as i can appreciate that other people would rather have something else by default.

@elitak i'm working on resolving the conflicts right now. should i leave it at 19.09 or update it to 20.03 which was released yesterday? 😀

also: i'm a bit perplexed by this f5da257 which is what's conflicting. what i had was working for debian 10 on digital ocean. maybe other places it doesn't work?

@elitak
Copy link
Owner

elitak commented Apr 21, 2020 via email

@manveru
Copy link

manveru commented Jun 12, 2020

@Kiwi any update on this?

@Kiwi
Copy link
Author

Kiwi commented Jun 12, 2020

@Kiwi any update on this?

I haven't finished fixing the merge conflicts. I was thinking about this the other day though. I have a bit more time now than I did so I should get back to it soon (I haven't been doing much with it lately).

@bbenne10 bbenne10 mentioned this pull request Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants