-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: fix: Restructure HELM charts, secrets encryption #20
base: dev
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR restructures the Helm charts organization and implements secrets encryption using SOPS. The changes include splitting the Helm templates into component-specific directories, updating the configuration to use encrypted secrets, and modifying the deployment structure to support secure secret management. Class diagram for updated secret managementclassDiagram
class decrypt_secrets {
+load_secrets() str
+file_path : str
}
note for decrypt_secrets "This class handles the decryption of secrets using SOPS."
class secrets_encrypted_yaml {
+gh_access_token : str
+cosign : dict
+intermediate_registry_token : str
}
decrypt_secrets --> secrets_encrypted_yaml : "decrypts"
class load_secrets {
+gh_access_token : str
+cosign_password : str
+cosign_private_key : str
+intermediate_registry_token : str
}
decrypt_secrets --> load_secrets : "returns"
note for load_secrets "This class represents the decrypted secrets."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @akash2237778 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please remove the kubeconfig credentials that were accidentally committed in helm/templates/pubgrade-webserver/deployment.yaml
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Modified directory structure, encrypted secrets using sops
Summary by Sourcery
Restructure the Helm charts and encrypt secrets using SOPS. Update the directory structure for better organization and maintainability. Integrate SOPS for secrets management and update the Dockerfile to include SOPS installation. Refactor deployment configurations to align with the new Helm chart structure.
Enhancements:
Build:
Deployment: