Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enforce semantic PRs; PR template #70

Merged
merged 3 commits into from
Jun 20, 2023
Merged

ci: enforce semantic PRs; PR template #70

merged 3 commits into from
Jun 20, 2023

Conversation

anuragxxd
Copy link
Member

@anuragxxd anuragxxd commented Jun 20, 2023 •
edited
Loading

Description

Please include a summary of the change and the relevant issue(s) it resolves, if any (otherwise delete that line).

Fixes #33

In addition to implementing the enforcement of semantic pull request titles, this update addresses the following configuration concerns within the project:

  • Conflict Detection in Pull Requests: The system now checks for conflicts within pull requests, ensuring a smoother merging process.
  • Improved Pull Request Template: The previous pull request template was excessively long and cumbersome, containing unnecessary elements. The new template has been streamlined to provide only essential information, simplifying the pull request creation process.

Checklist

Please go through the following checklist to ensure that your change is ready for review.

  • My code follows the contributing guidelines of this project.
  • I am aware that all my commits will be squashed into a single commit, using the PR title as the commit message.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • I have updated the user-facing documentation to describe any new or changed behavior.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have not reduced the existing code coverage.

Comments

If there are unchecked boxes in the list above, but you would still like your PR to be reviewed or considered for merging, please describe here why boxes were not checked.

@anuragxxd anuragxxd changed the title ci(pr_eval): enforce semantic pull requests ci(pr_eval): enforce semantic PR's & PR template Jun 20, 2023
@anuragxxd anuragxxd changed the title ci(pr_eval): enforce semantic PR's & PR template ci(pr_eval): enforce semantic PR's & PR template debug Jun 20, 2023
@anuragxxd anuragxxd changed the title ci(pr_eval): enforce semantic PR's & PR template debug ci(pr_eval): enforce semantic PR's & PR template Jun 20, 2023
@anuragxxd anuragxxd changed the title ci(pr_eval): enforce semantic PR's & PR template ci(pr_eval): enforce semantic PR's & PR template debug Jun 20, 2023
@anuragxxd anuragxxd changed the title ci(pr_eval): enforce semantic PR's & PR template debug ci(pr_eval): enforce semantic PR's & PR template Jun 20, 2023
ci(pr_eval): enforce semantic PR's & PR template
9b9a5ee 
Fixes #33 In addition to implementing the enforcement of semantic pull request titles, this update
addresses the following configuration concerns within the project: Conflict Detection in Pull
Requests: The system now checks for conflicts within pull requests, ensuring a smoother merging
process. Improved Pull Request Template: The previous pull request template was excessively long and
cumbersome, containing unnecessary elements. The new template has been streamlined to provide only
essential information, simplifying the pull request creation process.

fix #33
@anuragxxd anuragxxd marked this pull request as ready for review June 20, 2023 08:43
@anuragxxd anuragxxd requested a review from uniqueg June 20, 2023 08:45
uniqueg
uniqueg approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@uniqueg uniqueg changed the title ci(pr_eval): enforce semantic PR's & PR template ci: enforce semantic PRs; PR template Jun 20, 2023
uniqueg
uniqueg requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, after changing the PR title, the workflow fails with a message that the scope is missing. It's a good test for how well this PR works :) However, I don't agree that a scope is necessary. A scope makes sense in big projects, or in the scope of the monorepo to say if a change affects the TRS or WES component etc. I don't think for CI it makes a lot of sense, it's not like we have a dozen different workflows or more. Also, this PR affects two CI workflows, so just having one in the scope is not quite accurate. In fact, the PR template is arguably not even directly related to CI (but okay, in this case).

Anyway, please allow PR titles not to have a scope. Or at least require it only for fix and feat PRs.

@anuragxxd
Copy link
Member Author

Make sense @uniqueg, fixed it!

@anuragxxd anuragxxd requested a review from uniqueg June 20, 2023 18:52
@uniqueg
Copy link
Member

uniqueg commented Jun 20, 2023

Great! 🙏

@anuragxxd anuragxxd merged commit fa62ec3 into main Jun 20, 2023
@anuragxxd anuragxxd deleted the ci/#33 branch June 20, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uniqueg uniqueg uniqueg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: enforce semantic pull requests
2 participants
@anuragxxd @uniqueg