-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ci #9
Conversation
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
Reviewer's Guide by SourceryThis pull request enhances the documentation and development workflow by updating the README.md, improving the Code of Conduct, and refining the pull request template. It also updates the CI configuration for better dependency management and modifies the release workflow to use a different secret name. Significant changes include the addition of new badges, Makefile commands, improved documentation configuration, and various GitHub Actions workflows for code quality, testing, PR validation, and release management. File-Level Changes
Tips
|
changing the base to be able to check CI, this is not supposed to be merged in main but maybe in basic-structure branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 5 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
8500a67
to
889523b
Compare
7ab65f1
to
dde784c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟡 Documentation: 5 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
ed97b27
to
191b0fb
Compare
@uniqueg @psankhe28 finally this fixes all the issues that we have been facing hopefully. CI for code test are failing because this repo is does not have @uniqueg for anyone to now create a new repo with all the test passing would be to create the repo and be sure to generate docs using |
See #3 (comment) and the comment above, @JaeAeich & @psankhe28 |
refer to #10 |
Summary by Sourcery
This pull request introduces significant enhancements to the project structure, including a revamped README.md, a Makefile for common tasks, Sphinx configuration for documentation, multiple GitHub Actions workflows for CI/CD, a Code of Conduct, a pull request template, pre-commit hooks, and placeholder test files. Additionally, it includes configuration files for Read the Docs and YAML linting.