-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cruft): change GH update token #12
Conversation
Reviewer's Guide by SourceryThis pull request addresses issue #11 by updating the GitHub token references in the documentation and GitHub Actions workflow. Additionally, it refactors test functions in the integration and unit test files by removing pytest fixture decorators and renaming the functions for better clarity. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please ensure that the removal of the
pytest
import in the test files doesn't affect any other parts of the tests that might still require it.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@uniqueg I am not sure about this but changed the token, for if we need we can merge it first. AAH I see tus_handlers PR has already been merged. Leave it!! Then we can take care of this later. Close the PR please if this isn;t what you meant. |
how about we make changes to the repo this week, and you can just create a copy of the token (GITHUB_TOKEN) and add it to the org, if we get a PR on moday, all good and we can go ahead with this or else checkout whats wrong. |
{{ cookiecutter.project_name }}/tests/test_integration/test_init.py
Outdated
Show resolved
Hide resolved
merging this first, will add one more commit for the typo to #15 and merge after this. |
Description
Checklist
project, including, in particular, with regard to any style guidelines
specification; in particular, it clearly indicates
that a change is a breaking change
using the PR title as the commit message
changed behavior
or updated existing ones (only for Python, TypeScript, etc.)
docstrings) for all packages/modules/functions/classes/
methods or updated existing ones
works
Comments
Summary by Sourcery
Fix the GitHub token name in the update workflow and README. Refactor test fixtures to standard test functions in integration and unit tests.
Bug Fixes:
Enhancements:
Documentation: