-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Docker image #24
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR adds Docker image support to the project by modifying the cookiecutter configuration to include a new option for Docker image generation. Architecture diagram for Docker image integrationgraph TD;
A[Project Configuration] -->|Modified| B[Cookiecutter Configuration];
B -->|Added| C[Docker Image Option];
C --> D[Docker Image Generation];
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR checklist. We need to ensure all requirements are met, particularly regarding documentation and testing.
- The PR description is empty except for the issue reference. Please provide context about what this Docker image support will entail and how it will be implemented.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@uniqueg Docker build and push CI is still left, but since elixir's docker account name is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the empty GH Actions workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add content or remove
Description
Checklist
project, including, in particular, with regard to any style guidelines
specification; in particular, it clearly indicates
that a change is a breaking change
using the PR title as the commit message
changed behavior
or updated existing ones (only for Python, TypeScript, etc.)
docstrings) for all packages/modules/functions/classes/
methods or updated existing ones
works
Comments
Summary by Sourcery
New Features: