Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add RO-Crate OpenAPI specs #25

Closed
wants to merge 9 commits into from
Closed

Conversation

Rahuljagwani
Copy link
Collaborator

Work done

  • Write OpenAPI specs related to ROCrates only.
  • Write FOCA config (for testing specs).
  • Initialize FOCA application.
  • Write setup.py to package the service.

Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start @Rahuljagwani. Don't be intimidated by all the comments, just want to make sure everything is very clean and consistent ;-)

README.md Outdated Show resolved Hide resolved
crate-db/api/crate-db-specs.modified.yaml Outdated Show resolved Hide resolved
crate-db/api/crate-db-specs.yaml Outdated Show resolved Hide resolved
crate-db/api/crate-db-specs.yaml Outdated Show resolved Hide resolved
crate-db/api/crate-db-specs.yaml Outdated Show resolved Hide resolved
crate-db/ga4gh/controllers/server.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
crate-db/__init__.py Outdated Show resolved Hide resolved
crate-db/config.yaml Outdated Show resolved Hide resolved
@Rahuljagwani Rahuljagwani requested a review from uniqueg June 2, 2024 18:32
@uniqueg
Copy link
Member

uniqueg commented Jun 4, 2024

As I said, yesterday, @Rahuljagwani - please remove everything except the specs from this PR, open other PRs (ci, docs, build, chore) for the other files/issues and then (re-)request reviews on all PRs.

Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting there :) Still there may be some small things in the operations, but I don't think there will be more than one additional reviewing round here. Next time I will also review the models, but I guess for now there's already enough to update.

crate_db/api/crate_db_specs.yaml Show resolved Hide resolved
crate_db/api/crate_db_specs.yaml Show resolved Hide resolved
crate_db/api/crate_db_specs.yaml Show resolved Hide resolved
crate_db/api/crate_db_specs.yaml Show resolved Hide resolved
crate_db/api/crate_db_specs.yaml Show resolved Hide resolved
crate_db/api/crate_db_specs.yaml Show resolved Hide resolved
crate_db/api/crate_db_specs.yaml Show resolved Hide resolved
crate_db/api/crate_db_specs.yaml Show resolved Hide resolved
crate_db/api/crate_db_specs.yaml Show resolved Hide resolved
crate_db/api/crate_db_specs.yaml Show resolved Hide resolved
@Rahuljagwani Rahuljagwani mentioned this pull request Jun 4, 2024
@uniqueg uniqueg changed the title write initial rocrate operation specs chore: add RO-Crate OpenAPI specs Jun 4, 2024
@uniqueg uniqueg requested review from uniqueg and removed request for uniqueg June 21, 2024 09:29
.github/workflows/checks.yaml Show resolved Hide resolved
crate_db/api/crate_db_specs.yaml Show resolved Hide resolved
crate_db/api/crate_db_specs.yaml Show resolved Hide resolved
crate_db/api/crate_db_specs.yaml Show resolved Hide resolved
@uniqueg
Copy link
Member

uniqueg commented Jun 21, 2024

Closing in favor of #29 (all comments to the OpenAPI specs have been resolved in that PR)

@uniqueg uniqueg closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants