build: upgrade pymongo to 4.7.2 #213
Conversation
There was a problem hiding this comment.
I assumed the db port in petstore-access-control differs from the db port for petstore in order to be able to run both simultaneously. If this is the case, should I also change the port for the app container?
There was a problem hiding this comment.
That's not a bad idea. However, they may always be port conflicts for any given user, regardless of what ports we use. In any case, it's a different issue and nobody requested it, so let's leave the ports as they were here (i.e., please roll back 12345 to 27017).
There was a problem hiding this comment.
On another note: I think it would make sense to also upgrade MongoDB to the latest version in the docker-compose.yml files for the two example apps in this PR.
There was a problem hiding this comment.
Ah that makes sense I'll get to changing those thanks. The reason I changed the port was because the db port is 12345 in the mock data that is used by the access control tests. Should I change the port in the mock data to 27017 instead?
There was a problem hiding this comment.
Sorry, I didn't see your reply. I think what's in the mock data shouldn't matter, it's just a different config, any port should work. But let's keep the more standard 27017 port for the petstore apps. More generally, let's only change what's necessary in any given PR :)
Speaking of which, I didn't quite understand which unit tests failed because of the port in #214. I will comment there.
uniqueg
changed the title
uniqueg
changed the title
uniqueg
changed the title
There was a problem hiding this comment.
Please have a look at the open thread. Also, I'm concerned about the failing tests. They are not your fault, but I can't publish a release before these are fixed. So that will delay things. Try not to get blocked by this by using your local FOCA branch that has this issue fixed.
|
Closing in favor of #220 which builds on this PR |
Description
Fixes #212.
Type of change
Checklist: