Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null data checks #117

Open
JaeAeich opened this issue Feb 26, 2024 · 3 comments
Open

fix: null data checks #117

JaeAeich opened this issue Feb 26, 2024 · 3 comments
Assignees
Labels
flag: good 1st issue Good for newcomers

Comments

@JaeAeich
Copy link

Description

While fetching the data from notion, if the data is null or empty, there currently aren't any checks to gracefully handle these issues, which breaks the site. Add check on data to validate it before using a map, filter etc finc on them.

Info

Some of such functions are in utils such as solution.js and contributor.js. Check for more if present in the repo 🙂 .

Issue

image

@JaeAeich JaeAeich added the flag: good 1st issue Good for newcomers label Feb 26, 2024
@Chaitanya674
Copy link
Contributor

Chaitanya674 commented Feb 26, 2024

I want to solve this issue can you please assign me ? also after adding the null check if the data in null what do we need to display on the UI part ?

@uniqueg
Copy link
Member

uniqueg commented Feb 29, 2024

Thanks @Chaitanya674 - please go ahead. As for what to show if the data is null - I guess it depends on what is missing. I would propose that the first thing to do is to look through the codebase and enumerate the cases here in this issue, possibly as a table together with a proposal how to gracefully handle the missing data, i.e., what to show instead.

We can then discuss that proposal before you start implementing it.

@uniqueg
Copy link
Member

uniqueg commented Feb 29, 2024

My bad, just seen that you already provided a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: good 1st issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants