Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null data checks #120

Merged
merged 3 commits into from
Mar 6, 2024
Merged

fix: null data checks #120

merged 3 commits into from
Mar 6, 2024

Conversation

Chaitanya674
Copy link
Contributor

Fixes : null data checks #117

  • I created a null check where the utils/contributors.js and utils/solutions.js in order to send the data as an empty array [].
  • because If we dont send this well have bunch of errors same as described in the issue.
  • the frontend error display work on the .length parameter of array if its 0 then the UI changes to no contributors found.
  • I have run a linter test as well.

Copy link

vercel bot commented Feb 27, 2024

@Chaitanya674 is attempting to deploy a commit to the elixir-cloud-aai Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 8:40am

Copy link
Member

@anuragxxd anuragxxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Chaitanya674, Thanks for the PR! LGTM, but can you please remove the console logs from the client side. Thanks

@Chaitanya674
Copy link
Contributor Author

yeah sure

@uniqueg uniqueg changed the title fixed : null data checks fix: null data checks Feb 29, 2024
@anuragxxd
Copy link
Member

Thanks @Chaitanya674 for the PR, will merge!

@anuragxxd anuragxxd merged commit 43c97ae into elixir-cloud-aai:dev Mar 6, 2024
1 check passed
@Chaitanya674
Copy link
Contributor Author

Thanks @Chaitanya674 for the PR, will merge!

Happy to contribute : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants