You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
TES v1.1 defines an ignore_error field as a property of an executor (defined here). Currently, the TesExecutor model does not have this attribute. As a result, the following error occurs when a response with the ignore_error is provided:
TypeError: Executor.__init__() got an unexpected keyword argument 'ignore_error'
Full traceback:
Executor causing error:
Software
Using proTES with Funnel
The text was updated successfully, but these errors were encountered:
Thanks for reporting. This issue is due to Funnel, but not proTES, having adopted TES v1.1.0. The library that throws this error is py-tes.
A few points:
Upgrading py-tes to use the v1.1.0 branch should resolve this issue, but it's possible that we might run into other issues. For example, proTES may not forward the ignore_error value.
Alternatively, downgrading Funnel to a version that adopts v1.0.0 should also fix the issue. However, as far as I know, the latest Funnel version addresses a number of issues and is not just an upgrade to TES v1.1.0, so this would rather be a short-term solution.
The best way forward is probably to upgrade the proTES models to properly support v1.1.0, but making sure that it remains backwards-compatible.
Apart from dealing with ignore_error in one way or another, py-tes should not actually throw this error. This is because additionalProperties is not set to false in the TES specs, meaning that returning additional specs is not violating the specs and should not throw an error. We should open an issue about that.
Do you want to take care of these issues, @athith-g? That is:
Pick one of solutions 1.-3. to make the immediate problem go away.
Open an issue in the py-tes repo to let Liam and Kyle know that they should handle additional properties gracefully.
Describe the bug
TES v1.1 defines an
ignore_error
field as a property of an executor (defined here). Currently, the TesExecutor model does not have this attribute. As a result, the following error occurs when a response with theignore_error
is provided:TypeError: Executor.__init__() got an unexpected keyword argument 'ignore_error'
Full traceback:
Executor causing error:
Software
Using proTES with Funnel
The text was updated successfully, but these errors were encountered: