Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle additional properties #64

Open
athith-g opened this issue Jun 10, 2024 · 1 comment
Open

Handle additional properties #64

athith-g opened this issue Jun 10, 2024 · 1 comment

Comments

@athith-g
Copy link

Currently, py-tes throws errors when encountering properties that are not in the TES specs. For example, when using py-tes v0.4.2 with funnel v0.11.0, the presence of ignore_error in the response body produces the following traceback (from proTES #176):

Screenshot 2024-06-07 at 3 34 46 PM

However, since additionalProperties is not false in the TES specs, any additional spec provided should be handled without throwing an error.

@uniqueg
Copy link
Collaborator

uniqueg commented Jun 11, 2024

Thanks for reporting @athith-g. I agree that py-tes should handle additional props gracefully - the current implementation is not spec-compliant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants