Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil prefix with references #593

Merged
merged 6 commits into from
Jan 26, 2024
Merged

Fix nil prefix with references #593

merged 6 commits into from
Jan 26, 2024

Conversation

greg-rychlewski
Copy link
Member

Closes #590

There are 2 things I wasn't sure about:

  1. Is there a way to mark a struct field as deprecated? Or should I just leave a comment?
  2. I am still populating :prefix because I assumed removals only happen during new major versions

josevalim
josevalim reviewed Jan 26, 2024
View reviewed changes
lib/ecto/migration.ex Outdated Show resolved Hide resolved
josevalim
josevalim approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And yes, we cannot remove the field. The only way to deprecate it is via docs (for now).

@greg-rychlewski greg-rychlewski merged commit 38d2f7e into elixir-ecto:master Jan 26, 2024
10 checks passed
@greg-rychlewski greg-rychlewski deleted the reference_prefix branch January 26, 2024 13:35
@adamu adamu mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

References inside a prefixed table cannot reference an unprefixed table
2 participants
@greg-rychlewski @josevalim