Skip to content

Commit

Permalink
Update editorial_board_guide.md
Browse files Browse the repository at this point in the history
  • Loading branch information
korbinib authored Oct 27, 2023
1 parent e918d1e commit 9787c25
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions pages/contribute/editorial_board_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,14 @@ More information about these topics can be found in the GitHub documentation:

## Review pull requests

If contributors make a pull request to make changes, by default the editors that are responsible for files that will be changed by the PR will be assigned and notified. All PR should be assigned to one of the editors. Before merging a PR, pages' tags, and tools and resources' tags should be checked and assigned according to the established tagging system. The editor who provides the last approval to a PR should also merge it.
If contributors make a pull request to make changes, by default the editors that are responsible for files that will be changed by the PR will be assigned and notified. All PR should be assigned to one of the editors. The use of the suggestion for specific changes to the line or lines (by clicking {% octicon file-diff height:16 %}) in the comment field) For more infomration about this please visit the [GitHub documentation page: starting a review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request#starting-a-review).

Before merging a PR, pages' tags, and tools and resources' tags should be checked and assigned according to the established tagging system. The editor who provides the last approval to a PR should also merge it.

## Link a pull request to an issue

When you make a pull request resolving an issue, it is possible to link this pull request to that specific issue. This can be easily done by writing in the conversation of the PR: `closes #number_of_issue`, or `fixes #number_of_issue` or even `resolves #number_of_issue`. This is definitely applicable when authors first open an issue announcing a change or requesting a new page, followed up by the pull request.
For more information about this topic please visit the [GitHub documentation page](https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue).
For more information about this topic please visit the [GitHub documentation page: Linking a pull request to an issue](https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue).

## Adding a new event

Expand Down

0 comments on commit 9787c25

Please sign in to comment.