Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metaclass conflict #522

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix metaclass conflict #522

merged 2 commits into from
Sep 26, 2024

Conversation

moustaphacheikh
Copy link
Collaborator

IMG_2861

Description

Resolved a metaclass conflict between CoreModel (ModelBase) and NotifyMixin (ABCMeta) by refactoring NotifyMixin:

  • Removed ABC inheritance and @abstractmethod
  • Replaced abstract methods with NotImplementedError
  • Removed the now unnecessary CoreNotifyMeta
  • Updated models to inherit directly from CoreModel and NotifyMixin

@moustaphacheikh moustaphacheikh removed the request for review from neoflex September 26, 2024 08:34
aleuk0
aleuk0 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@aleuk0 aleuk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@moustaphacheikh moustaphacheikh merged commit 93b452e into develop Sep 26, 2024
2 checks passed
@moustaphacheikh moustaphacheikh deleted the fix-metaclass-conflict branch September 26, 2024 14:39
@vildead vildead mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuk0 aleuk0 aleuk0 approved these changes

@neoflex neoflex Awaiting requested review from neoflex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moustaphacheikh @aleuk0