Forbid or replace empty targets in HTTP/1.1 requests #469
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
changed the title
|
@ruslandoga can we add a test that verifies the behavior of this with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
Right now Mint allows sending empty target in the request line for HTTP/1.1. I think it should either forbid such requests or replace them with
/:Current behaviour
this results in
POST HTTP/1.1This PR
Forbidding seems easier since replacing
""with"/"might be surprising and not always correct, and there is already a:skip_target_validationoption to disable "forbidding" if necessary.