-
Notifications
You must be signed in to change notification settings - Fork 127
Improve README setup instructions #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It should be auto-inferred, and if not, extra_applications is correct instead: https://elixirforum.com/t/why-do-we-use-application-function-in-mix-exs/23834/2
I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I have one question about the Repo.pool/0
function
adapter: Mongo.Ecto | ||
|
||
def pool() do | ||
Ecto.Adapter.lookup_meta(__MODULE__).pid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mweidner037 In our code base, we do %{pid: pid} = Ecto.Repo.Registry.lookup(__MODULE__)
. Should we switch to this form or are they equivalent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They appear to be equivalent, though perhaps the Ecto.Adapter.lookup_meta
form is preferable since that function is actually documented. I'll update it when changing the Mongo Ecto versions.
Fixes #196
With thanks to @sriedel for the detailed feedback!