Skip to content

Commit

Permalink
add --strict to credo and ensure conformity
Browse files Browse the repository at this point in the history
  • Loading branch information
Adriano Mitre committed Oct 18, 2020
1 parent e7f1d3c commit 4d80f09
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- run: mix deps.get
- run: mix format --check-formatted
- run: mix compile --warnings-as-errors
- run: mix credo
- run: mix credo --all --strict

test:
name: Test
Expand Down Expand Up @@ -53,7 +53,8 @@ jobs:
elixir-version: ${{matrix.elixir}}

- run: mix deps.get --only test
- run: mix test --color 2>/tmp/tests.stderr
- name: Run mix test
run: mix test --color 2>/tmp/tests.stderr
- name: Make sure tests do not have warnings
run: "! grep -v 'warning: ' /tmp/tests.stderr"
if: matrix.warnings_as_errors
1 change: 0 additions & 1 deletion lib/norm/core/all_of.ex
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,3 @@ defmodule Norm.Core.AllOf do
end
end
end

2 changes: 1 addition & 1 deletion test/norm/contract_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ defmodule Norm.ContractTest do
defmodule Reflection do
use Norm

def int(), do: spec(is_integer())
def int, do: spec(is_integer())

@contract foo(a :: int(), int()) :: int()
def foo(a, b), do: a + b
Expand Down

0 comments on commit 4d80f09

Please sign in to comment.