add --strict to credo and ensure conformity

elixir-toniq · Oct 29, 2020 · 8a69747 · 8a69747
1 parent ec5a59e
commit 8a69747
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -18,7 +18,7 @@ jobs:
       - run: mix deps.get
       - run: mix format --check-formatted
       - run: mix compile --warnings-as-errors
-      - run: mix credo
+      - run: mix credo --all --strict
 
   test:
     name: Test
@@ -53,7 +53,8 @@ jobs:
           elixir-version: ${{matrix.elixir}}
 
       - run: mix deps.get --only test
-      - run: mix test --color 2>/tmp/tests.stderr
+      - name: Run mix test
+        run: mix test --color 2>/tmp/tests.stderr
       - name: Make sure tests do not have warnings
         run: "! grep -v 'warning: ' /tmp/tests.stderr"
         if: matrix.warnings_as_errors
diff --git a/lib/norm/core/all_of.ex b/lib/norm/core/all_of.ex
@@ -25,4 +25,3 @@ defmodule Norm.Core.AllOf do
     end
   end
 end
-
diff --git a/test/norm/contract_test.exs b/test/norm/contract_test.exs
@@ -94,7 +94,7 @@ defmodule Norm.ContractTest do
     defmodule Reflection do
       use Norm
 
-      def int(), do: spec(is_integer())
+      def int, do: spec(is_integer())
 
       @contract foo(a :: int(), int()) :: int()
       def foo(a, b), do: a + b

diff --git a/test/norm/core/delegate_test.exs b/test/norm/core/delegate_test.exs
@@ -2,7 +2,7 @@ defmodule Norm.Core.DelegateTest do
   use Norm.Case, async: true
 
   defmodule TreeTest do
-    def spec() do
+    def spec do
       schema(%{
         "value" => spec(is_integer()),
         "left" => delegate(&TreeTest.spec/0),
Original file line number	Diff line number	Diff line change
Expand Up		@@ -25,4 +25,3 @@ defmodule Norm.Core.AllOf do
		end
		end
		end