feat!: be resilient to LSP protocol errors #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhanberg
force-pushed
the
better-error-logging
branch
from
700d4e7 to
533b3d8
Compare
mhanberg
changed the title
Previously, if a user passed non compliant reply to a request, the framework would raise and your server would crash. Previously, if a client sent an invalid request or notification, the framework would raise, not providing a good error for the user or the LSP author. Now, in those three cases, if the framework sees a non-compliant response, it will respond to the client with a relevant error code and message. Note: in the case of notifications, we just log, as there is nothing to respond to.
mhanberg
force-pushed
the
better-error-logging
branch
from
533b3d8 to
a766421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a user passed non compliant reply to a request, the
framework would raise and your server would crash.
Previously, if a client sent an invalid request or notification, the
framework would raise, not providing a good error for the user or the
LSP author.
Now, in those three cases, if the framework sees a non-compliant
response, it will respond to the client with a relevant error code and
message.
Note: in the case of notifications, we just log, as there is nothing to
respond to.