Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #118
Basically - changed the logic to the following:
e.g.
for https://collections.yadvashem.org/en/names/14035251
call (step 2) to: https://yv360.yadvashem.org/api/Names/GetSingleFullDetails?id=1100850&lang=en&source=Page%20of%20Testimony
response is in the following format:
Then, convert the
details
list to an object by using aid
to field_name mapping, with value fromvalue
.Then parse it.
Also - since they may be duplicates, take the first value.
Bonus:
Refactor
addEventData
to a common class.Other things to add (probably in a different PR) - the ability to fetch an image.