Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_createSuggestions empty value fix #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

_createSuggestions empty value fix #117

wants to merge 1 commit into from

Conversation

efpont
Copy link

@efpont efpont commented Apr 26, 2018

fixes #106

@elf-pavlik
Copy link

nice fix, i hope you can get merged soon!

jhuesos
jhuesos reviewed May 28, 2018
View reviewed changes
Copy link
Collaborator

@jhuesos jhuesos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Sorry back from long holidays. I would help to merge this PR faster if you added some tests. Otherwise, the fix won't be release until I add some tests to cover the problem.

And many thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhuesos jhuesos jhuesos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show-results-on-focus doesn't work in demo
3 participants
@efpont @elf-pavlik @jhuesos