Use keypress instead of keyup in onEnter #12
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a problem specific to a particular situation.
Japanese text are input by pressing Enter key twice.
The problem is that
onEnter
handles event on the timing (1) instead of (2).For example, when we Japanese type
kansuu
, there are many way to express it. (1) Showkansuu
directly (2) convert toかんすう
(3) convert to関数
(4) convert to巻数
... This functionality is called IME (Input Method Editor).When we want to input "関数って最高だよね", we first type
kansuu
and then choose関数
using Enter key. Now we haven't finished inputting the whole text yet, butonEnter
event is unexpectedly emitted.As far as I know, using
keypress
instead ofkeyup
solves this problem. But I'm not sure if this change causes any downside or not. I will really appreciate if someone could review this.