Change description of List.member #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because this function is called 'contains' in many languages, I hit this documentation, searched for 'contains,' and didn't find the right method. Putting 'contains' in the description for 'member' help with this
evancz
pushed a commit
that referenced
this pull request
Aug 2, 2015
Change description of List.member
|
Great idea! I'd be curious to know the list of languages that use that naming convention (and which languages do other things). Perhaps the best move is to rename this to Anyway, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because this function is called 'contains' in many languages, I hit
this documentation, searched for 'contains,' and didn't find the right
method. Putting 'contains' in the description for 'member' help with this