Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure user is logged in & authorised #382

Merged
merged 1 commit into from
Feb 28, 2017
Merged

ensure user is logged in & authorised #382

merged 1 commit into from
Feb 28, 2017

Conversation

chris18890
Copy link
Collaborator

@chris18890 chris18890 commented Feb 15, 2017 •
edited
Loading

ensure user is logged in before exporting data, fixes #348

ramgarden
ramgarden reviewed Feb 16, 2017
View reviewed changes
Copy link
Contributor

@ramgarden ramgarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a VERY simple change and looks OK to merge. user_id() is the proper way to check if user is logged in everywhere else so this is valid.

@elplatt elplatt merged commit 26b6134 into elplatt:dev Feb 28, 2017
@chris18890 chris18890 deleted the auth_export branch February 28, 2017 16:54
@chris18890 chris18890 mentioned this pull request Feb 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramgarden ramgarden ramgarden left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris18890 @ramgarden @elplatt