Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F java structs2 enhancement #17

Merged
merged 3 commits into from
Nov 4, 2024
Merged

F java structs2 enhancement #17

merged 3 commits into from
Nov 4, 2024

Conversation

ben-elttam
Copy link
Collaborator

No description provided.

@ben-elttam
[Rules] rename web.xml filter url-mapping
9aecb5a
@ben-elttam
[Rules] Move test to subdir
ca9e93d
@ben-elttam
[Rules] Update rule id
a785b07 
- Also update comment regarding tree-sitter XML parsers
- Also drop pre-commit python language version
@daniel-elttam
Copy link
Collaborator

semgrep-rules-test is failing:

Error: Unable to resolve action returntocorp/semgrep-rules-test-action, not found

daniel-elttam
daniel-elttam approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@daniel-elttam daniel-elttam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest we raise a new GitHub issue to rewrite rules with the new treesitter xml support, but otherwise the changes itself look fine.

@ben-elttam
Copy link
Collaborator Author

semgrep-rules-test is failing:

Error: Unable to resolve action returntocorp/semgrep-rules-test-action, not found

I've raised #20 to remove this workflow as returntocorp removed that action.

@ben-elttam
Copy link
Collaborator Author

I'd suggest we raise a new GitHub issue to rewrite rules with the new treesitter xml support, but otherwise the changes itself look fine.

Yes, I'll do this in a future PR.
Thanks for the review.

@ben-elttam ben-elttam removed the request for review from matt-elttam November 4, 2024 23:52
@ben-elttam ben-elttam merged commit 40743d5 into main Nov 4, 2024
2 of 3 checks passed
@ben-elttam ben-elttam deleted the f-java-structs2-enhancement branch November 4, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-elttam daniel-elttam daniel-elttam approved these changes

Assignees

@ben-elttam ben-elttam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-elttam @daniel-elttam