Add proper integration test w/ build + launch; refactor CMakeLists.txt to accommodate #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Most significantly, refactored cmake source to provide *basic* configurations suitable for integration tests and library builds in the top CMakeLists.txt and moved most library specific cmake source and hunter-package configurations to src/CMakeLists.txt * update build-ios.sh toolchain to use libcxx * refactor top CMakeLists.txt * make cmakelists.txt suitable for both library/project builds and integration/bootstrap tests (for post installation binary tests) * move packages from CMakeLists.txt -> src/CMakeLists.txt; better grouping of cmake configs * add DRISHTI_BUILD_INTEGRATION_TESTS option * populate 3rdparty src + hunter packages side-by-side with hunter_add_package() + find_package() calls (more modular) * convert drishti-example-eye.cpp from a standard app to a drishti_test_main() application to leverage automated device testing (the integration tests were started as an entirely independently CMakeLitst.txt project, but I ended up having to duplicate much of the core drishti/CMakeLists.txt cmake code to run the automated tests, so it made more sense to make the top level drishti/CMakeLists.txt file manage both the core library builds and the integration test) * update the bin/build-integration-test.sh file to use top level CMakeLists.txt for building + running the integratino test: add —test, add new polly `—output` option to avoid conflicts with the library build tree * various cmakelists.txt cleanups and formatting * TODO: move include_directories() calls to `target` equivalents where possible. * enable the per texture annotation callback in facefinder drawing * dont’ display pupil by default in eye annotations (facefinder drawing) * make pupil drawing optional facefinder drawing * add bash script to provide summary of build release * bump verison to v0.8.0 * Public SDK Eye::eyelids type was updated to use static Array<> type * include + use drishti_split_symbols on public sdk * reduce drishti::sdk::Eye Array<T,128> default size to 128 * add smake function to split debug symbols on install * add cmake function to check linker flags
ruslo
reviewed
Jan 30, 2017
| message("+++ ${CMAKE_CONFIGURATION_TYPES} +++" ) | ||
| message("--- ${CMAKE_BUILD_TYPE} ---") | ||
| set(CMAKE_XCODE_ATTRIBUTE_GCC_INLINES_ARE_PRIVATE_EXTERN "YES") | ||
| set(CMAKE_XCODE_ATTRIBUTE_GCC_SYMBOLS_PRIVATE_EXTERN "YES") |
There was a problem hiding this comment.
What flags are we adding by this? Probably it's a candidate for adding to toolchain.
There was a problem hiding this comment.
I think you are right.
Added: #290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Most significantly, refactored cmake source to provide basic configurations suitable for integration tests and library builds in the top CMakeLists.txt and moved most library specific cmake source and hunter-package configurations to src/CMakeLists.txt
—outputoption to avoid conflicts with the library build treetargetequivalents where possible.