#2199 Allow expression text editor to be expandable (#2200)

Signed-off-by: srikant <[email protected]> Co-authored-by: Matt Howard <[email protected]>
elyra-ai · Oct 10, 2024 · f7edcc2 · f7edcc2
1 parent 5640aa3
commit f7edcc2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/...nvas/src/common-properties/controls/expression/expression-builder/expression-builder.scss b/...nvas/src/common-properties/controls/expression/expression-builder/expression-builder.scss
@@ -47,7 +47,11 @@ $operator-margin: 50%;
 	margin-bottom: 0;
 
 	.elyra-CodeMirror {
+		/* Allow codemirror container to resize on drag */
+		resize: vertical;
+		overflow: auto;
 		.cm-editor {
+			min-height: inherit; /* Inherit min-height to restrict resize below certain width  */
 			background: $field-01;
 		}
 	}

diff --git a/canvas_modules/common-canvas/src/common-properties/controls/expression/expression.jsx b/canvas_modules/common-canvas/src/common-properties/controls/expression/expression.jsx
@@ -424,7 +424,7 @@ class ExpressionControl extends React.Component {
 					<div ref={ (ref) => (this.expressionEditorDiv = ref) } data-id={ControlUtils.getDataId(this.props.propertyId)}
 						className={className}
 					>
-						<div className={codemirrorClassName} ref={this.editorRef} style={{ height: this.state.expressionEditorHeight }} />
+						<div className={codemirrorClassName} ref={this.editorRef} style={{ height: this.state.expressionEditorHeight, minHeight: minLineHeight }} />
 						<ValidationMessage state={this.props.state} messageInfo={messageInfo} inTable={this.props.tableControl} />
 					</div>
 				</div>