Restore Slider input borders and add disabled for error input

Signed-off-by: srikant <[email protected]>
elyra-ai · Feb 2, 2024 · f9e3e21 · f9e3e21
1 parent 21aef26
commit f9e3e21
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/canvas_modules/common-canvas/src/common-properties/controls/slider/slider.scss b/canvas_modules/common-canvas/src/common-properties/controls/slider/slider.scss
@@ -22,24 +22,23 @@
 			min-width: unset; // Default Carbon Component Slider has a fixed min-width of 12.5rem so unset it to make it responsive
 		}
 	}
-	.bx--number[data-invalid] { // carbon override to not display error
-		.bx--form-requirement { // carbon override to not display error
-			display: none;
-		}
-	}
 	&.error {
-		input {
+		.bx--text-input--invalid, .bx--text-input {
+			outline: unset;
+			outline-offset: unset;
+		}
+		input[type="number"]:not([disabled]), input[type="number"]:focus:not([disabled]) {
 			border: 2px solid $support-01;
 		}
 	}
 	&.warning {
-		input:not([disabled]) {
+		.bx--text-input--invalid, .bx--text-input {
+			outline: unset;
+			outline-offset: unset;
+		}
+		input[type="number"]:not([disabled]), input[type="number"]:focus:not([disabled]) {
 			border: 2px solid $support-03;
 		}
 	}
-	.bx--text-input--invalid, .bx--text-input {
-		outline: unset;
-		outline-offset: unset;
-		border: unset;
-	}
+
 }
diff --git a/canvas_modules/harness/test_resources/parameterDefs/slider_paramDef.json b/canvas_modules/harness/test_resources/parameterDefs/slider_paramDef.json
@@ -178,7 +178,7 @@
         "control": "slider",
         "min_value": 10,
         "max_value": 100,
-        "increment": 10,
+        "increment": 1,
         "description": {
           "default": "Slider error with range more than Max'"
         }