Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1619 Notification panel temporarily appearing in test harness #1620

Merged
merged 4 commits into from
Nov 7, 2023
Merged

#1619 Notification panel temporarily appearing in test harness #1620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7857521
#1619 Notification panel temporarily appearing in test harness
tomlyn Nov 6, 2023
1f95f28
Prevent annimate
tomlyn Nov 7, 2023
f7b2b70
Change name
tomlyn Nov 7, 2023
8462fdc
Merge branch 'main' into temp_notif_panel_appears
tomlyn Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion canvas_modules/common-canvas/src/notification-panel/notification-panel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ class NotificationPanel extends React.Component {
constructor(props) {
super(props);
this.state = {};

this.firstTime = true;
this.logger = new Logger("NotificationPanel");
this.handleNotificationPanelClickOutside = this.handleNotificationPanelClickOutside.bind(this);
this.closeNotificationPanel = this.closeNotificationPanel.bind(this);
Expand Down Expand Up @@ -160,7 +162,10 @@ class NotificationPanel extends React.Component {
return null;
}

const notificationPanelClassName = this.props.isNotificationOpen ? "" : "panel-hidden";
let notificationPanelClassName = this.props.isNotificationOpen ? "" : "panel-hidden";
notificationPanelClassName += this.firstTime ? "" : " panel-transition";
this.firstTime = false;

const notificationHeader = this.props.notificationConfig && this.props.notificationConfig.notificationHeader
? this.props.notificationConfig.notificationHeader
: DEFAULT_NOTIFICATION_HEADER;
Expand Down
6 changes: 4 additions & 2 deletions canvas_modules/common-canvas/src/notification-panel/notification-panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,19 @@ $toolbar-button-height: 41px; // Allow one extra pixel for the toolbar border

// This section adds an ease-in ease-out effect for the notification-panel-container
.notification-panel-container {
transition: 0.25s ease-in-out;
opacity: 1;
margin-top: 0;
z-index: 2; // Ensure panel appears on top of bottom panel.

&.panel-hidden {
transition: 0.25s ease-in-out;
display: block;
opacity: 0;
visibility: hidden;
}

&.panel-transition {
transition: 0.25s ease-in-out;
}
}

.notification-panel {
Expand Down
Loading