Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1685 : Set tooltip visible based on closest for link click #1686

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

srikant-ch5
Copy link
Contributor

@srikant-ch5 srikant-ch5 commented Feb 5, 2024

Fixes : #1685
Close tooltip when clicked on other ui elements other than tooltip and handle tooltip link click scenario.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@srikant-ch5 srikant-ch5 requested a review from nmgokhale February 5, 2024 10:56
@nmgokhale
Copy link
Member

nmgokhale commented Feb 5, 2024

@srikant-ch5

@srikant-ch5
Copy link
Contributor Author

srikant-ch5 commented Feb 6, 2024

Hi @nmgokhale I have updated Issue description, included issue number in PR description and have also updated the branch with main. Please review.

@nmgokhale nmgokhale merged commit e2177cd into elyra-ai:main Feb 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep tooltip visible when clicked on a link
2 participants