Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1717 Accessibility: Notification panel should be enabled for keyboard navigation #1718

Merged
merged 11 commits into from
Feb 27, 2024

Conversation

tomlyn
Copy link
Member

@tomlyn tomlyn commented Feb 23, 2024

Fixes: #1717

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@tomlyn tomlyn changed the title Notif panel in toolbar #1717 Accessibility: Notification panel should be enabled for keyboard navigation Feb 23, 2024
@tomlyn tomlyn self-assigned this Feb 23, 2024
@tomlyn tomlyn requested a review from nmgokhale February 23, 2024 23:20
@nmgokhale
Copy link
Member

Notification panel is partially cut off when opened -
Screenshot 2024-02-23 at 4 32 59 PM

@tomlyn
Copy link
Member Author

tomlyn commented Feb 24, 2024

Hi @Neha -- Thanks -- sorry I allocated you as reviewer too early since I knew I wasn't finished. I was just on auto pilot :(

@tomlyn
Copy link
Member Author

tomlyn commented Feb 26, 2024

OK I think its working now. Can you review/approve please? Sorry there are a lot of changes again

@nmgokhale
Copy link
Member

Toolbar button used to show blue bottom-border when notification panel is open -
Screenshot 2024-02-26 at 1 45 04 PM

Now it shows arrow without border -
Screenshot 2024-02-26 at 1 46 56 PM

Is this design approved?

@tomlyn tomlyn merged commit 9864601 into elyra-ai:main Feb 27, 2024
3 checks passed
@tomlyn tomlyn deleted the notif_panel_in_toolbar branch February 27, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: Notification panel should be enabled for keyboard navigation
2 participants