Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1721 Replace codemirror-lang-r package with @codemirror/legacy-modes #1722

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

nmgokhale
Copy link
Member

@nmgokhale nmgokhale commented Mar 2, 2024

Fixes #1721

Jest tests are failing with @codemirror/legacy-modes package as well. To fix jest tests, host applications should add this config in package.json file -

"jest": {
    "transformIgnorePatterns": [
      "node_modules/@elyra/canvas/node_modules/(?!@codemirror/legacy-modes)"
    ]
  }

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@nmgokhale nmgokhale self-assigned this Mar 2, 2024
@nmgokhale nmgokhale requested a review from matthoward366 March 2, 2024 00:45
@nmgokhale
Copy link
Member Author

At path canvas_modules/common-canvas/node_modules/@codemirror/legacy-modes/mode, I do see r.cjs file. Hopefully host applications won't see any issue in CommonJS format.

Screenshot 2024-03-01 at 4 40 37 PM

Copy link
Member

@matthoward366 matthoward366 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@matthoward366 matthoward366 merged commit e761d9b into elyra-ai:main Mar 4, 2024
3 checks passed
@nmgokhale nmgokhale deleted the use-codemirror-legacy-modes branch March 4, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace codemirror-lang-r package with @codemirror/legacy-modes
2 participants