Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2057 Workaround unit test failures related to Carbon Tabs #2058

Closed
wants to merge 1 commit into from

Conversation

caritaou
Copy link
Member

This is a workaround for #2057 until we get a fix from Carbon

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@caritaou caritaou requested a review from tomlyn July 11, 2024 18:05
Copy link
Member

@tomlyn tomlyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Jests tests ran OK for me with this PR

Copy link

@matthoward366
Copy link
Member

@caritaou should this be closed?

@caritaou
Copy link
Member Author

caritaou commented Aug 7, 2024

Yes this can be closed, we already picked up the new Carbon version with the fix

@caritaou caritaou closed this Aug 7, 2024
@caritaou caritaou deleted the cou-jest-tests-failures branch August 7, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants