Skip to content

Test suite rewrite and dependency updates #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mikkelam
Copy link

@mikkelam mikkelam commented Jun 24, 2025

Completely rewrote the test suite since the old one was just commented out static plugin code that didn't test anything useful.

Changes:

  • Updated @elysiajs/eden from 1.2.0 to 1.3.0
  • Removed broken index.test.ts with commented static plugin tests
  • Added comprehensive test coverage:
    • core.test.ts - Core OpenTelemetry functionality
    • integration.test.ts - Elysia framework integration
    • advanced.test.ts - Advanced tracing features
    • test-setup.ts - Shared test utilities, loaded with bun --preload

Test improvements:

  • 31 tests covering OpenTelemetry behavior
  • Proper span lifecycle testing with capture utilities
  • HTTP method tracing, middleware integration, nested spans
  • Error handling, concurrent requests, trace propagation
  • Real integration tests using eden treaty client

Unrelated
If the author is happy with this PR, i would love to improve the otel package to also handle logging

@mikkelam mikkelam marked this pull request as ready for review June 25, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant