Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dap-go-debug-program #326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bbenchen
Copy link

@bbenchen bbenchen commented Aug 7, 2020

No description provided.

@yyoncho
Copy link
Member

yyoncho commented Aug 12, 2020

cc @shackra

@shackra
Copy link

shackra commented Aug 12, 2020

@yyoncho got this from Go debug stderr:

(node:27901) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

Process Go Debug stderr finished

I have node v13.11.0

also, in Warnings I got the following:

Warning (emacs): Initialize request failed: unrecognized request

I've attached some logs, but it short: no luck.

lsp-log gopls.txt
lsp-log.txt

@h3poteto
Copy link

I can launch go debug program using this change.

This warning appear in stderr:

(node:10631) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

But it is no problem to run go debug.

@yyoncho
Copy link
Member

yyoncho commented Sep 22, 2020

@h3poteto most likely it is due to the node version.

@yyoncho
Copy link
Member

yyoncho commented Sep 22, 2020

@shackra can you crosscheck with vscode? In particular, check what is the process that vscode is starting.

@h3poteto
Copy link

@yyoncho Yes, I see. The warning disappear under node 9.x.
And I think that cause of the warning is debugAdapter.js, so it should be fixed in vscode-go.

@shackra
Copy link

shackra commented Sep 23, 2020

@shackra can you crosscheck with vscode? In particular, check what is the process that vscode is starting.

It's hard to tell, ps aux | grep node yells nothing meaningful:

jorge       7728  0.5  0.7 611244 118276 ?       Sl   20:08   0:01 /opt/visual-studio-code/code --type=renderer --disable-color-correct-rendering --no-sandbox --field-trial-handle=8475732384693727212,10885319093976006155,131072 --disable-features=LayoutNG,PictureInPicture,SpareRendererForSitePerProcess --lang=es-419 --standard-schemes=vscode-webview,vscode-webview-resource --secure-schemes=vscode-webview,vscode-webview-resource --bypasscsp-schemes --cors-schemes=vscode-webview,vscode-webview-resource --fetch-schemes=vscode-webview,vscode-webview-resource --service-worker-schemes --app-path=/opt/visual-studio-code/resources/app --node-integration --no-sandbox --no-zygote --native-window-open --preload=/opt/visual-studio-code/resources/app/out/vs/base/parts/sandbox/electron-browser/preload.js --disable-remote-module --background-color=#1e1e1e --disable-blink-features=Auxclick --num-raster-threads=4 --enable-main-frame-before-activation --service-request-channel-token=3551170435785335084 --renderer-client-id=7 --no-v8-untrusted-code-mitigations --shared-files=v8_context_snapshot_data:100,v8_natives_data:101
jorge       7796  4.6  1.4 12484288 238992 ?     SLl  20:09   0:10 /opt/visual-studio-code/code --type=renderer --disable-color-correct-rendering --no-sandbox --field-trial-handle=8475732384693727212,10885319093976006155,131072 --disable-features=LayoutNG,PictureInPicture,SpareRendererForSitePerProcess --lang=es-419 --standard-schemes=vscode-webview,vscode-webview-resource --secure-schemes=vscode-webview,vscode-webview-resource --bypasscsp-schemes --cors-schemes=vscode-webview,vscode-webview-resource --fetch-schemes=vscode-webview,vscode-webview-resource --service-worker-schemes --app-path=/opt/visual-studio-code/resources/app --node-integration --webview-tag --no-sandbox --no-zygote --native-window-open --preload=/opt/visual-studio-code/resources/app/out/vs/base/parts/sandbox/electron-browser/preload.js --disable-remote-module --background-color=#1e1e1e --num-raster-threads=4 --enable-main-frame-before-activation --service-request-channel-token=264608822746804061 --renderer-client-id=8 --no-v8-untrusted-code-mitigations --shared-files=v8_context_snapshot_data:100,v8_natives_data:101
jorge       9420  0.4  0.6 402504 106220 ?       Sl   20:09   0:00 /opt/visual-studio-code/code /opt/visual-studio-code/resources/app/extensions/json-language-features/server/dist/node/jsonServerMain --node-ipc --clientProcessId=7828
jorge      12975  0.0  0.0   8860  2156 pts/1    S+   20:12   0:00 grep node

I can tell you that I run this version of node on my system:

$ node --version
v14.2.0

@yyoncho
Copy link
Member

yyoncho commented Sep 23, 2020

@shackra can you crosscheck with vscode? In particular, check what is the process that vscode is starting.

It's hard to tell, ps aux | grep node yells nothing meaningful:

jorge       7728  0.5  0.7 611244 118276 ?       Sl   20:08   0:01 /opt/visual-studio-code/code --type=renderer --disable-color-correct-rendering --no-sandbox --field-trial-handle=8475732384693727212,10885319093976006155,131072 --disable-features=LayoutNG,PictureInPicture,SpareRendererForSitePerProcess --lang=es-419 --standard-schemes=vscode-webview,vscode-webview-resource --secure-schemes=vscode-webview,vscode-webview-resource --bypasscsp-schemes --cors-schemes=vscode-webview,vscode-webview-resource --fetch-schemes=vscode-webview,vscode-webview-resource --service-worker-schemes --app-path=/opt/visual-studio-code/resources/app --node-integration --no-sandbox --no-zygote --native-window-open --preload=/opt/visual-studio-code/resources/app/out/vs/base/parts/sandbox/electron-browser/preload.js --disable-remote-module --background-color=#1e1e1e --disable-blink-features=Auxclick --num-raster-threads=4 --enable-main-frame-before-activation --service-request-channel-token=3551170435785335084 --renderer-client-id=7 --no-v8-untrusted-code-mitigations --shared-files=v8_context_snapshot_data:100,v8_natives_data:101
jorge       7796  4.6  1.4 12484288 238992 ?     SLl  20:09   0:10 /opt/visual-studio-code/code --type=renderer --disable-color-correct-rendering --no-sandbox --field-trial-handle=8475732384693727212,10885319093976006155,131072 --disable-features=LayoutNG,PictureInPicture,SpareRendererForSitePerProcess --lang=es-419 --standard-schemes=vscode-webview,vscode-webview-resource --secure-schemes=vscode-webview,vscode-webview-resource --bypasscsp-schemes --cors-schemes=vscode-webview,vscode-webview-resource --fetch-schemes=vscode-webview,vscode-webview-resource --service-worker-schemes --app-path=/opt/visual-studio-code/resources/app --node-integration --webview-tag --no-sandbox --no-zygote --native-window-open --preload=/opt/visual-studio-code/resources/app/out/vs/base/parts/sandbox/electron-browser/preload.js --disable-remote-module --background-color=#1e1e1e --num-raster-threads=4 --enable-main-frame-before-activation --service-request-channel-token=264608822746804061 --renderer-client-id=8 --no-v8-untrusted-code-mitigations --shared-files=v8_context_snapshot_data:100,v8_natives_data:101
jorge       9420  0.4  0.6 402504 106220 ?       Sl   20:09   0:00 /opt/visual-studio-code/code /opt/visual-studio-code/resources/app/extensions/json-language-features/server/dist/node/jsonServerMain --node-ipc --clientProcessId=7828
jorge      12975  0.0  0.0   8860  2156 pts/1    S+   20:12   0:00 grep node

I can tell you that I run this version of node on my system:

$ node --version
v14.2.0

Maybe it runs with the same node version as code? Can you test with node 9 as suggested by @h3poteto ?

@shackra
Copy link

shackra commented Sep 23, 2020

with version:

➜ asdf current nodejs
9.11.2

I just get this:

imagen

@shackra
Copy link

shackra commented Sep 23, 2020

Which is to say: I get nothing newsworthy, what are we looking again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants