Skip to content

Commit

Permalink
[chore] Update comments with old document/onHover API (#4627)
Browse files Browse the repository at this point in the history
Why?:
- In the current form of the LSP specification `document/onHover` is replaced by
  `textDocument/hover`.

This change addresses the need by:
- Replace `document/onHover` with `textDocument/hover`

Co-authored-by: Tobias Heinlein <[email protected]>
  • Loading branch information
niontrix and Tobias Heinlein authored Nov 28, 2024
1 parent c3aa25d commit e095b31
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lsp-mode.el
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ supported by the language server."
:group 'lsp-mode)

(defcustom lsp-eldoc-render-all nil
"Display all of the info returned by document/onHover.
"Display all of the info returned by textDocument/hover.
If this is set to nil, `eldoc' will show only the symbol information."
:type 'boolean
:group 'lsp-mode)
Expand Down Expand Up @@ -5693,7 +5693,7 @@ When language is nil render as markup if `markdown-mode' is loaded."
(car (s-lines (s-trim (lsp--render-element contents)))))

(defun lsp--render-on-hover-content (contents render-all)
"Render the content received from `document/onHover' request.
"Render the content received from `textDocument/hover' request.
CONTENTS - MarkedString | MarkedString[] | MarkupContent
RENDER-ALL - nil if only the signature should be rendered."
(cond
Expand Down

0 comments on commit e095b31

Please sign in to comment.