Fix so that lsp-semgrep-languages will take effect immediately #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating `lsp-semgrep-languages` didn't take effect until a restart (or recompile of lsp-semgrep.el). This is because it's `:activation-fn` is `(apply 'lsp-activate-on lsp-semgrep-languages)` which effectively embeds the versions rather than checking the value of the variable each time.
|
I'm not sure what would be wrong with the windows-latest, or why the 3 other checks haven't finished. Is it something I should worry about, or a problem with the CI right now? |
There are errors from that snapshot, so no need to worry about it! The other three checks should be removed since we've already dropped support for Emacs 26.3. |
yyoncho
approved these changes
Oct 27, 2023
|
Thank you for contributing to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
lsp-semgrep-languagesdidn't take effect until a restart (or recompile of lsp-semgrep.el). This is because it's:activation-fnis(apply 'lsp-activate-on lsp-semgrep-languages)which effectively embeds the versions rather than checking the value of the variable each time.