lsp-mode: Fix sending shutdown message #4167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two related problems. First, according to the spec (https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#shutdown) the shutdown message should have no parameters. rust-analyzer and erlang-language-platform respond with an "unable to deserialized error" when given an empty map instead. e.g. LSP :: (error Failed to deserialize shutdown: invalid type: map, expected unit; {}) But this was hidden because the condition case swallows the error info and always reports timeout. A genuine timeout is now reported as LSP :: (error Timeout while waiting for response. Method: shutdown)
yyoncho
approved these changes
Sep 10, 2023
nverno
added a commit
to nverno/lsp-mode
that referenced
this pull request
Oct 16, 2023
* master: (27 commits) Rename blacklist to blocklist (emacs-lsp#4173) Introduce a function to disable a call for particular method for a server (emacs-lsp#4171) Fix `lsp-completion--company-match` freezing emacs-lsp#4192 (emacs-lsp#4193) Bump the magik language server to 0.8.1 (emacs-lsp#4195) Add configuration to use new experimental ondisk cache for lsp-kotlin (emacs-lsp#4138) lsp-erlang: add setting for types on hover (emacs-lsp#4188) Make it possible to override lsp-cmake server command (emacs-lsp#4182) lsp-erlang: update erlang-language-platform download file names (emacs-lsp#4187) clojure: add paredit refactorings Fix typo in php-guide.md (emacs-lsp#4183) Bump magik language server to 0.8.0 (emacs-lsp#4176) Bump elixir-ls version (emacs-lsp#4178) Remove unbalanced parenthesis and double-quote in comments (emacs-lsp#4177) MDX support (emacs-lsp#4141) lsp-erlang: Add semantic token support for erlang-language-platform (emacs-lsp#4166) lsp-mode: Fix sending shutdown message (emacs-lsp#4167) lsp-erlang: update ELP download file names (emacs-lsp#4165) Add Move language client (emacs-lsp#4155) Add support for python-lsp-server pyls-isort plugin. (emacs-lsp#4163) Updating Crystal LSP (emacs-lsp#4156) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two related problems.
First, according to the spec the shutdown message should have no parameters.
rust-analyzer and erlang-language-platform respond with an "unable to deserialized error" when given an empty map instead. e.g.
LSP :: (error Failed to deserialize shutdown: invalid type: map, expected unit; {})But this was hidden because the condition case swallows the error info and always reports timeout.
A genuine timeout is now reported as
LSP :: (error Timeout while waiting for response. Method: shutdown)