Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unbalanced parenthesis and double-quote in comments #4177

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

fredericgiquel
Copy link
Contributor

There is an unbalanced parenthesis in comments of lsp--workspace structure. It generates an error when you try to access documentation with helpful and Emacs 29 (see Wilfred/helpful#329).

This PR just removes the faulty (and useless) parenthesis and double-quote.

@yyoncho
Copy link
Member

yyoncho commented Sep 23, 2023

Thank you!

@yyoncho yyoncho merged commit c7b3d1c into emacs-lsp:master Sep 23, 2023
13 of 14 checks passed
nverno added a commit to nverno/lsp-mode that referenced this pull request Oct 16, 2023
* master: (27 commits)
  Rename blacklist to blocklist (emacs-lsp#4173)
  Introduce a function to disable a call for particular method for a server (emacs-lsp#4171)
  Fix `lsp-completion--company-match` freezing emacs-lsp#4192 (emacs-lsp#4193)
  Bump the magik language server to 0.8.1 (emacs-lsp#4195)
  Add configuration to use new experimental ondisk cache for lsp-kotlin (emacs-lsp#4138)
  lsp-erlang: add setting for types on hover (emacs-lsp#4188)
  Make it possible to override lsp-cmake server command (emacs-lsp#4182)
  lsp-erlang: update erlang-language-platform download file names (emacs-lsp#4187)
  clojure: add paredit refactorings
  Fix typo in php-guide.md (emacs-lsp#4183)
  Bump magik language server to 0.8.0 (emacs-lsp#4176)
  Bump elixir-ls version (emacs-lsp#4178)
  Remove unbalanced parenthesis and double-quote in comments (emacs-lsp#4177)
  MDX support (emacs-lsp#4141)
  lsp-erlang: Add semantic token support for erlang-language-platform (emacs-lsp#4166)
  lsp-mode: Fix sending shutdown message (emacs-lsp#4167)
  lsp-erlang: update ELP download file names (emacs-lsp#4165)
  Add Move language client (emacs-lsp#4155)
  Add support for python-lsp-server pyls-isort plugin. (emacs-lsp#4163)
  Updating Crystal LSP (emacs-lsp#4156)
  ...
@fredericgiquel fredericgiquel deleted the unbalanced-parenthesis branch November 19, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants